]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
gdm/authPrompt: Unset the entry reference on destruction
authorMarco Trevisan (Treviño) <mail@3v1n0.net>
Mon, 25 Aug 2025 12:25:49 +0000 (14:25 +0200)
committerMarge Bot <marge-bot@gnome.org>
Sat, 30 Aug 2025 01:36:14 +0000 (01:36 +0000)
We use the internal entry as the reference to the text entry that is
currently in use, but during destruction we do not unset it, thus the
garbage collector may requires further cycles to actually release it.

Simplify its job here, improves 572d011894c9b490b8a17ad7db6adec335fbb017

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3850>

js/gdm/authPrompt.js

index 32a36c9607fe1a90d59307475a9f3990fe0146ba..8dcbfe30031723d07f3dd2a7e49e2d260273e6bf 100644 (file)
@@ -134,6 +134,7 @@ export const AuthPrompt = GObject.registerClass({
         this._inactiveEntry = null;
         this._userVerifier.destroy();
         this._userVerifier = null;
+        this._entry = null;
     }
 
     on_key_press_event(event) {